Changes &Option<String> to Option<&str> in kubectl example #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
approved these changes
May 19, 2023
Signed-off-by: David Herberth <github@dav1d.de>
Dav1dde
force-pushed
the
kubectl-option-str
branch
from
1c89994
to
45df4b9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 68 68
Lines 5380 5380
=======================================
Hits 3954 3954
Misses 1426 1426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1216 - minor change switching
&Option<String>to the more idomaticOption<&str>which also requires one less clone.