Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy --fix on runtime pedantics #1302

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Clippy --fix on runtime pedantics #1302

merged 3 commits into from
Oct 5, 2023

Conversation

clux
Copy link
Member

@clux clux commented Oct 2, 2023

Some that have cropped up in new clippy versions.

See the recent boringssl PR's clippy output for the lints it fixes.

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1302 (1912e33) into main (83368df) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
- Coverage   72.31%   72.30%   -0.02%     
==========================================
  Files          75       75              
  Lines        6347     6347              
==========================================
- Hits         4590     4589       -1     
- Misses       1757     1758       +1     
Files Coverage Δ
kube-runtime/src/utils/stream_subscribe.rs 96.39% <ø> (ø)
kube-runtime/src/utils/mod.rs 62.96% <0.00%> (ø)
kube-runtime/src/watcher.rs 38.13% <0.00%> (ø)

... and 1 file with indirect coverage changes

@clux clux marked this pull request as ready for review October 2, 2023 19:39
@clux clux requested review from nightkr and Dav1dde October 2, 2023 19:39
@clux clux added the changelog-exclude changelog excluded prs label Oct 2, 2023
@clux clux added this to the 0.87.0 milestone Oct 2, 2023
@clux clux merged commit 20f7d13 into main Oct 5, 2023
16 of 17 checks passed
@clux clux deleted the clippy1-10-23 branch October 5, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant