Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeconfig allow certificate_authority_data not present in ExecAuthCluster #1432

Merged
merged 1 commit into from Mar 20, 2024

Conversation

ljun20160606
Copy link
Contributor

@ljun20160606 ljun20160606 commented Mar 19, 2024

Motivation

#1431

Solution

I found if we use #[serde(with = "module")]. It will check if field is present. Let's check on serde-rs/serde#1728. We can add #[serde(default)] to fix this.

@clux clux added the changelog-fix changelog fix category for prs label Mar 19, 2024
@clux clux modified the milestone: 0.89.0 Mar 19, 2024
@clux
Copy link
Member

clux commented Mar 19, 2024

hey, thanks for this, looks like an oversight, happy to merge, but are you able to --signoff the commit? (see DCO check)

@clux clux linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.3%. Comparing base (77852d9) to head (8fa8ad1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1432     +/-   ##
=======================================
+ Coverage   72.3%   72.3%   +0.1%     
=======================================
  Files         76      76             
  Lines       6527    6528      +1     
=======================================
+ Hits        4717    4718      +1     
  Misses      1810    1810             
Files Coverage Δ
kube-client/src/config/file_config.rs 75.5% <ø> (ø)

... and 1 file with indirect coverage changes

@ljun20160606
Copy link
Contributor Author

hey, thanks for this, looks like an oversight, happy to merge, but are you able to --signoff the commit? (see DCO check)

Done.

Signed-off-by: ljun20160606 <ljun20160606@gmail.com>
@clux clux changed the title feat: allow certificate_authority_data not present Kubeconfig allow certificate_authority_data not present in ExecAuthCluster Mar 20, 2024
@clux clux merged commit 3d2b464 into kube-rs:main Mar 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing field certificate-authority-data when exec credential plugins
2 participants