Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement http_body trait methods #1452

Merged
merged 1 commit into from
Mar 30, 2024
Merged

implement http_body trait methods #1452

merged 1 commit into from
Mar 30, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 29, 2024

Implements http_body::Body trait's methods.

@tottoto
implement http body trait method
044452d 
Signed-off-by: tottoto <tottotodev@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.1%. Comparing base (ff5a9e4) to head (044452d).

Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1452     +/-   ##
=======================================
- Coverage   72.1%   72.1%   -0.0%     
=======================================
  Files         78      78             
  Lines       6594    6604     +10     
=======================================
+ Hits        4749    4756      +7     
- Misses      1845    1848      +3
Files Coverage Δ
kube-client/src/client/body.rs 83.8% <70.0%> (-4.1%) ⬇️

clux
clux approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks a lot!

@clux clux added this to the 0.90.0 milestone Mar 30, 2024
@clux clux added the changelog-fix changelog fix category for prs label Mar 30, 2024
@clux clux merged commit 02c99f2 into kube-rs:main Mar 30, 2024
17 checks passed
@tottoto tottoto deleted the http-body branch March 30, 2024 16:34
@clux clux mentioned this pull request Apr 2, 2024
Closed
@clux clux changed the title implement http body trait method implement http_body trait method Apr 3, 2024
@clux clux changed the title implement http_body trait method implement http_body trait methods Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Milestone
0.90.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tottoto @clux