move from hyper-proxy2 to hyper-http-proxy

[aviramha]

No description provided.

[aviramha]

Sorry about the spam @clux - first time adding an annoying dependency like this to a library ;P

[clux]

np, appreciate the quick fixes here!

[aviramha]

@clux would appreciate your help figuring out how to solve it - the hyper-proxy crate doesn't support having both rustls/openssl features used together. How should I solve it?

[clux]

..actually, no that breaks all features builds. maybe we just support rustls for https proxy until hyper-proxy2 can support having both enabled?

[aviramha]

Fine by me. I thought to do it as a cheap shot then I thought using the sub-feature thingy is easy, (it could've been..)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.9%. Comparing base (57320a8) to head (304fab6).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1502   +/-   ##
=====================================
  Coverage   74.9%   74.9%           
=====================================
  Files         78      78           
  Lines       6864    6864           
=====================================
  Hits        5136    5136           
  Misses      1728    1728           

Files	Coverage Δ
kube-client/src/client/builder.rs	58.3% <0.0%> (ø)

... and 1 file with indirect coverage changes

[clux]

possibly a legit concern from cargo deny here; hyper-proxy2 does not really update dependencies frequently leading to duplicate rustls deps and this can slow down rustls adoption speed.

i don't think the duplicate versions are super problematic atm, because we are not using the same ssl parameters for the proxy connector (so mismatching struct errors shouldn't happen). at the very least a note in deny.toml about the ignore duplicate for it would be helpful

[aviramha]

I forked the repo and updated, sent a PR upstream and changed kube rs to use our fork for the moment.
I hate it when I have two versions of same dependency in our deptree, caused me so much pain ;(

[clux]

Sounds good!

It might also be worth adding the rustls-webpki feature for the rustls fork.
EDIT: oh, wait you cannot disable the old webpki 🤔

[aviramha]

Not sure about the new failures?

[clux]

The errors:

0.23.8/src/crypto/mod.rs:260:14:
no process-level CryptoProvider available -- call CryptoProvider::install_default() before this point

hints at aws_lc_rs lib, which we have not enabled yet. i guess hyper-proxy2 also needs to not enable that feature on rustls :/

[aviramha]

Okay I took ownership of that fork and did some refactoring there to be more friendly to kube-rs.
I can also make sure the fork is always up to date :)

[clux]

Your new upstream looks great to me. Thanks for doing this.