change event recorder cluster namespace to kube-system #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because publishing to "default" is a fallback thing. fixes #870 Signed-off-by: clux <sszynrae@gmail.com>
|
Might want to add a highlight for this, since it might require RBAC changes. |
nightkr
approved these changes
Apr 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 70.46% 70.48% +0.02%
==========================================
Files 61 61
Lines 4249 4249
==========================================
+ Hits 2994 2995 +1
+ Misses 1255 1254 -1
|
|
Agreed, will add a highlight in the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because publishing to "default" is a fallback thing.
fixes #870