Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend kubectl example with apply + edit and example improvements #897

Merged
merged 17 commits into from May 11, 2022
Merged

Extend kubectl example with apply + edit and example improvements #897

merged 17 commits into from May 11, 2022

Conversation

clux
Copy link
Member

@clux clux commented May 4, 2022 •
edited

Improves kubectl example - see this file)

Plus a general examples cleanup:

  • removed configmap_watcher (the least advanced one, and plenty of watcher examples already)
  • removed NAMESPACE evar use as a bad substitute for Api::default_namespaced + kns

rationale for last one: much better to let people rely on their namespace switchers like kns rather than having us implement NAMESPACE everywhere..

clux
clux commented May 5, 2022
View reviewed changes
examples/kubectl.rs Outdated Show resolved Hide resolved
@clux clux marked this pull request as ready for review May 5, 2022 10:05
@clux clux added the changelog-exclude changelog excluded prs label May 5, 2022
@clux clux requested a review from nightkr May 5, 2022 10:06
@clux clux changed the title Extend kubectl example with an apply method Extend kubectl example with apply + edit subcommands May 5, 2022
clux
clux commented May 5, 2022
View reviewed changes
examples/kubectl.rs Outdated Show resolved Hide resolved
@codecov-commenter

This comment was marked as off-topic.

Sign in to view
clux added 8 commits May 6, 2022 20:32
@clux
Extend kubectl with apply method
a2ac3d4 
Can apply yaml from multidoc files using helpers from #896

Signed-off-by: clux <sszynrae@gmail.com>
@clux
rebase with new helpers
5cb7e7f 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
extra error case
0f60996 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
add edit support as well
34af98a 
ok i will stop now. this is surprisingly easy.

Signed-off-by: clux <sszynrae@gmail.com>
@clux
avoid awkward cloning
35fd549 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
managed fields tweak
a2bff2f 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
add note after finding out kubectl is smart
f472362 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
less import after rebase
38b0150 
Signed-off-by: clux <sszynrae@gmail.com>
clux added 4 commits May 7, 2022 22:39
@clux
cleanup into methods on clap inst
9b69dff 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
cleanup dynamic_api example a bit
4a1f4e1 
no need to use NAMESPACE evars. people can use kns or similar to change
namespace. rely on default_namespaced.

Signed-off-by: clux <sszynrae@gmail.com>
@clux
Merge branch 'master' into kubectl-apply2
8925e8d
@clux
remove NAMESPACE evars across examples + configmap_watcher
2a3f63d 
better to let people rely on default_namespaced and switch with kns
also updates docs for these

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Extend kubectl example with apply + edit subcommands Extend kubectl example with apply + edit and example improvements May 7, 2022
clux added 2 commits May 7, 2022 23:11
@clux
fix log_stream example
0be7914 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
fix warning + build
bc8660c 
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added this to the 0.72.0 milestone May 9, 2022
@clux clux requested a review from kazk May 10, 2022 21:45
kazk
kazk approved these changes May 11, 2022
View reviewed changes
examples/kubectl.rs Outdated Show resolved Hide resolved
clux added 2 commits May 11, 2022 09:34
@clux
make verb an enum
e6c28ba 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
one less clone and tweak sentence
149074d 
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux merged commit 2d4a37d into master May 11, 2022
@clux clux deleted the kubectl-apply2 branch May 11, 2022 08:56
@clux clux mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees
No one assigned
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Milestone
0.72.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clux @codecov-commenter @kazk