Implements a secondary interface just for services #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaocw2020
reviewed
Sep 2, 2021
| @@ -141,6 +141,6 @@ var kubeVipSampleManifest = &cobra.Command{ | |||
| } | |||
|
|
|||
| b, _ := yaml.Marshal(p) | |||
| fmt.Printf(string(b)) | |||
| fmt.Print(string(b)) | |||
There was a problem hiding this comment.
Is it just for testing? It's better to delete it.
yaocw2020
reviewed
Sep 2, 2021
cmd/kube-vip-kubeadm.go
Outdated
| @@ -150,7 +152,7 @@ func autoGenLocalPeer() (*kubevip.RaftPeer, error) { | |||
| } | |||
| } | |||
| if a == "" { | |||
| return nil, fmt.Errorf("Unable to find local address") | |||
| return nil, fmt.Errorf("nable to find local address") | |||
There was a problem hiding this comment.
I think it should be unable.
yaocw2020
reviewed
Sep 2, 2021
pkg/kubevip/config_envvar.go
Outdated
| @@ -24,6 +24,9 @@ const ( | |||
| //vipInterface - defines the interface that the vip should bind too | |||
| vipInterface = "vip_interface" | |||
|
|
|||
| //vipInterface - defines the interface that the vip should bind too | |||
yaocw2020
reviewed
Sep 2, 2021
| @@ -24,6 +24,9 @@ const ( | |||
| //vipInterface - defines the interface that the vip should bind too | |||
| vipInterface = "vip_interface" | |||
|
|
|||
| //vipInterface - defines the interface that the vip should bind too | |||
| vipServicesInterface = "vip_servicesinterface" | |||
There was a problem hiding this comment.
From my perspect, services_vip_interface would be better than vip_servicesinterface. What do you think?
yaocw2020
reviewed
Sep 2, 2021
pkg/kubevip/config_types.go
Outdated
| @@ -63,6 +63,9 @@ type Config struct { | |||
| // Interface is the network interface to bind to (default: First Adapter) | |||
| Interface string `yaml:"interface,omitempty"` | |||
|
|
|||
| // Interface is the network interface to bind to (default: First Adapter) | |||
pkg/manager/services.go
Outdated
| @@ -90,18 +90,26 @@ func (sm *Manager) syncServices(service *v1.Service, wg *sync.WaitGroup) error { | |||
|
|
|||
| } | |||
|
|
|||
| // Detect if we're using a specific interface for services | |||
| var serciceInterface string | |||
pkg/manager/services.go
Outdated
| // Generate new Virtual IP configuration | ||
| newVip := kubevip.Config{ | ||
| VIP: newServiceAddress, //TODO support more than one vip? | ||
| Interface: sm.config.Interface, | ||
| Interface: serciceInterface, |
|
Thanks for the feedback, all issues addressed! |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an end user to specify a secondary interface that is used purely for services.
Or within the environment variables!