Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localhost to connect to manager #285

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Use localhost to connect to manager #285

merged 2 commits into from
Oct 13, 2021

Conversation

thebsdbox
Copy link
Collaborator

Instead of os.Hostname() just use the localhost as this is always present in the certificate SANs.

@thebsdbox
Copy link
Collaborator Author

Passed e2e tests, now deploying on a real cluster.

@thebsdbox
Copy link
Collaborator Author

Strange why that worked in kind but not in real life ... Anyway

Change api-server to kubernetes in kube-vip instead of localhost and add this to the hostAliases (which is what coreDNS would do anyway)

spec:
  hostAliases:
  - ip: "127.0.0.1"
    hostnames:
    - "kubernetes"

@thebsdbox thebsdbox mentioned this pull request Oct 12, 2021
Closed
@thebsdbox thebsdbox merged commit c94c15a into kube-vip:main Oct 13, 2021
@thebsdbox thebsdbox deleted the localhost branch October 13, 2021 10:10
@JumpMaster JumpMaster mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij Awaiting requested review from yastij

@detiber detiber Awaiting requested review from detiber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thebsdbox