Replace IPVS as the API server LoadBalancer #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebsdbox
added
control plane
stevesloka
reviewed
Oct 22, 2021
pkg/cluster/clusterLeader.go
Outdated
| log.Infof("Starting IPVS LoadBalancer") | ||
| portForwarder := loadbalancer.NewServer(c.VIP, c.LoadBalancerPort) | ||
| // TODO | ||
| lb, err := loadbalancer.NewIPVSLB("1.2.3.4", 6444) |
There was a problem hiding this comment.
nit: TODO still need fixed up?
pkg/cluster/clusterLeader.go
Outdated
| // TODO | ||
| lb, err := loadbalancer.NewIPVSLB("1.2.3.4", 6444) | ||
| if err != nil { | ||
| log.Error(err) |
There was a problem hiding this comment.
nit: Would be nice to have the error explain what's happening (e.g. error creating new IPVSLB or something).
pkg/cluster/clusterLeader.go
Outdated
| @@ -386,6 +366,97 @@ func (cluster *Cluster) StartLeaderCluster(c *kubevip.Config, sm *Manager, bgpSe | |||
| return nil | |||
| } | |||
|
|
|||
| // present | |||
| // LabelsWatcher will watch for labels created on nodes | |||
| func (sm *Manager) LabelsWatcher(lb *loadbalancer.IPVSLoadBalancer) error { | |||
There was a problem hiding this comment.
I've been looking at how to best do this. Might be able to throw some things we've done with Contour into the project to centralize this and separate the k8s specific bits out. I can share more as I pick through my GatewayAPI PR.
pkg/kubevip/config_generator.go
Outdated
| @@ -365,87 +365,12 @@ func ParseEnvironment(c *Config) error { | |||
| } | |||
| c.EnableLoadBalancer = b | |||
| // Load Balancer configuration | |||
| return parseEnvironmentLoadBalancer(c) | |||
| // return parseEnvironmentLoadBalancer(c) | |||
There was a problem hiding this comment.
Should this be commented out?
pkg/loadbalancer/ipvs.go
Outdated
| err := lb.client.CreateDestination(lb.loadBalancerService, dst) | ||
| // TODO: we either parse the IPVS configuration to see if a backend exists | ||
| // or if it already exists we just ignore this and continue ons | ||
| if err != nil && err != os.ErrExist { |
There was a problem hiding this comment.
nit: The err != nil is redundant
pkg/manager/watcher.go
Outdated
| // This file handles the watching of node annotations for configuration, it will exit once the annotations are | ||
| // present | ||
| // LabelsWatcher will watch for labels created on nodes | ||
| func (sm *Manager) LabelsWatcher(lb *loadbalancer.IPVSLoadBalancer) error { |
There was a problem hiding this comment.
Is this the same code as in clusterLeader.go?
yastij
reviewed
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the API-Server Loadbalancer with
IPVS