Monitor default VIP interface #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kube-vip chooses the default interface based on the default route. Once the default route changes, the default interface may be invalid. In this case, it would be better to crash the process. The pod will restart immediately if the kube-vip is deployed as a daemonset. Signed-off-by: yaocw2020 <yaocanwu@gmail.com>
yaocw2020
added a commit
to yaocw2020/harvester-network-controller
that referenced
this pull request
Dec 22, 2021
Leveraging the new feature kube-vip/kube-vip#273, the harvester network controller controller don't need the vip controller anymore. Dependency: kube-vip/kube-vip#339
thebsdbox
approved these changes
Dec 22, 2021
yaocw2020
commented
Dec 22, 2021
yaocw2020
added a commit
to yaocw2020/harvester-network-controller
that referenced
this pull request
Jan 12, 2022
Leveraging the new feature kube-vip/kube-vip#273, the harvester network controller controller don't need the vip controller anymore. Dependency: kube-vip/kube-vip#339
gitlawr
pushed a commit
to harvester/network-controller-harvester
that referenced
this pull request
Jan 17, 2022
Leveraging the new feature kube-vip/kube-vip#273, the harvester network controller controller don't need the vip controller anymore. Dependency: kube-vip/kube-vip#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kube-vip chooses the default interface based on the default route. Once the default route changes, the default interface is very likely invalid. In this case, it would be better to crash the process. The pod will restart immediately if the kube-vip is deployed as a daemonset.
Signed-off-by: yaocw2020 yaocanwu@gmail.com