support changing the VIP of services #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, would you consider deleting the pkg/service and only remaining the manager because it seems that the manager can support all the functions of the service module provided? @thebsdbox |
yaocw2020
force-pushed
the
supportChangingVIP
branch
from
4301997
to
89b54ec
Compare
- Support changing the VIP of services - Refactory the manager.syncServices to improve code readability Signed-off-by: yaocw2020 <yaocanwu@gmail.com>
yaocw2020
force-pushed
the
supportChangingVIP
branch
from
89b54ec
to
c81c8c1
Compare
|
Hi @yaocw2020, the duplicated |
thebsdbox
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue in the Harvester project: harvester/harvester#1834
Signed-off-by: yaocw2020 yaocanwu@gmail.com