Deprecate loadbalancerIP, use annotation to fetch service loadbalancerIP #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new annotation kube-vip.io/loadbalancerIPs to specify the loadbalancer ip for service Now ip address fetched from loadbalancer service are first fetched from annotation, then fallback to service spec Unit test Signed-off-by: lubronzhan <lzhan@vmware.com>
lubronzhan
force-pushed
the
topic/lubron/deprecate_loadbalancerip
branch
from
9223d19
to
a9932ec
Compare
|
Apologies... All documentation for kube-vip.io lives in the /website repo. |
|
Ohk, let me also create PR there |
Merged
|
Should I only update the website repo or both? |
|
Follow up PR here kube-vip/website#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ##457
PR in website: kube-vip/website#15
Related issue in kube-vip-cloud-provider kube-vip/kube-vip-cloud-provider#51
kube-vip.io/loadbalancerIPsto specify the loadbalancer ip for service