Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix LB annotations #553

Merged
merged 1 commit into from
May 3, 2023
Merged

fix LB annotations #553

merged 1 commit into from
May 3, 2023

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Apr 29, 2023

  • replace spec.annotations by metadata.annotations
  • clean the case when needed
  • remove svc. prefix

@tuxtof
fix LB annotations
b33da24 
Signed-off-by: Christophe Jauffret <reg-github@geo6.net>
@thebsdbox
Copy link
Collaborator

The /docs are being depreciated, all docs live in the website repository at this time.

@tuxtof
Copy link
Contributor Author

tuxtof commented Apr 29, 2023 •
edited

ok perfect i also update the website accordingly
kube-vip/website#20

@thebsdbox
Copy link
Collaborator

Awesome, thank you 🙏🏻

@thebsdbox thebsdbox merged commit e0a9e70 into kube-vip:main May 3, 2023
3 of 4 checks passed
@tuxtof tuxtof deleted the fix-lb-annotation branch May 3, 2023 10:39
@haijianyang haijianyang mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox Awaiting requested review from thebsdbox thebsdbox is a code owner

@yastij yastij Awaiting requested review from yastij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tuxtof @thebsdbox