-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add bgp metrics (bgp_session_info) #561
Conversation
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
da97bc5
to
4a2e72e
Compare
This is excellent ! (Thankyou ! ) |
Regarding the failing check: Is this something I broke? I think I didn't even touch these files...so I guess not? |
I think #557 should fix this, right? :) |
Yeah, the linter was updated recently and it's generating a load of noise in old code. 🙄 |
If this is good to go, I'm happy to merge as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
From my side, it's ready to merge. If there are any issues occurring or changes wanted by others, I will propose a follow up PR. |
As described in #547, this PR adds the metrics to monitor the current state of the bgp sessions.
The port of the peer is hard coded, since it is not currently possible to change the port in kube-vip. As soon as this feature is implemented, the port will be accessible by using the peers state, similar to
GetNeighborAddress()
.If this should be refactored later, just tell me and I append the 179 in the
peerDescription
directly.Example metrics look like this: