Update go dependencies #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrueg
force-pushed
the
update-deps-0623
branch
3 times, most recently
from
2d238d3
to
3355eac
Compare
mrueg
force-pushed
the
update-deps-0623
branch
3 times, most recently
from
6952719
to
5bc3f00
Compare
|
I have no idea why the linter keeps dying :-( .. what happens if you run the make check command locally? |
mrueg
force-pushed
the
update-deps-0623
branch
2 times, most recently
from
b03f7d0
to
a3884bd
Compare
|
I've updated golangci-lint hoping it fixes it. |
|
fwiw, there's a breaking change: cloudflare/ipvs@4d94efc which is using net/netip now, I've not bumped the dep past 0.9.1 because of this. |
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
@thebsdbox this should be ready to go now. |
lubronzhan
reviewed
Aug 9, 2023
| @@ -1,33 +1,33 @@ | |||
| module github.com/kube-vip/kube-vip | |||
|
|
|||
| go 1.18 | |||
| go 1.19 | |||
There was a problem hiding this comment.
Should it be 1.20 since you updated dockerfile to use 1.20 as base image
There was a problem hiding this comment.
not necessarily, as kube-vip would still build with 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we use recent versions.