Add environment variable for routing table type #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Sluis <timo.sluis@live.nl>
Signed-off-by: Timo Sluis <timo.sluis@live.nl>
|
Is this ready to merge? |
Signed-off-by: Timo Sluis <timo.sluis@live.nl>
Signed-off-by: Timo Sluis <timo.sluis@live.nl>
Signed-off-by: Timo Sluis <timo.sluis@live.nl>
Signed-off-by: Timo Sluis <timo.sluis@live.nl>
|
There are a few complaints from the CI, can these be addressed. I'd love to merge this in! |
|
Going to merge and fix locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to be able to bind the virtual IP addresses for outgoing connections, which only seems to work if we add our vip subnet to the local routing table with type local. This pull request adds the option to specify which type should be used when adding entries to the routing table.