ARP: Add node labeling for ARP mode DaemonSet deployment. #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is related to kube-vip#611, to configure the `CiliumEgressGatewayPolicy` EgressIP correctly. As this is not a very common usage for this project, there is a default disabled configuration flag added, `enable_node_labeling`. Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
Looks great! Thankyou |
|
done some extensive tests with Cilium and this patched version of kube-vip. It's working perfectly for me. |
|
Excellent, we love Cilium! I'll cut a new release soon! |
|
Hello, What do I have to do to make it work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is related to #611, to configure the CiliumEgressGatewayPolicy EgressIP correctly.
As this is not a very common usage for this project, there is a default disabled configuration flag added,
enable_node_labeling.The ClusterRole also needed patch rights to adjust the node labels.
Let me know what you think about the change, and where is the best place to document this feature.
Thank you!