Enable unit and e2e tests in CI #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-gaston
commented
Oct 3, 2023
Comment on lines
-80
to
+81
| "bgp/bgp-peers-0-peer-ip": "10.0.0.254", | ||
| "bgp/bgp-peers-0-src-ip": "10.0.0.1,10.0.0.2,10.0.0.3", | ||
| "bgp/bgp-peers-0-peer-ip": "10.0.0.1,10.0.0.2,10.0.0.3", | ||
| "bgp/bgp-peers-0-src-ip": "10.0.0.254", |
There was a problem hiding this comment.
If I'm not mistaken, these two expected values were swapped, the code that generates the peers looks correct, it was just the wrong expectation
g-gaston
force-pushed
the
unit-tests
branch
2 times, most recently
from
ed2896b
to
141bb5a
Compare
g-gaston
commented
Oct 3, 2023
| @@ -98,7 +98,7 @@ var _ = Describe("kube-vip broadcast neighbor", func() { | |||
|
|
|||
| manifestPath := filepath.Join(tempDirPath, "kube-vip-ipv4.yaml") | |||
|
|
|||
| for i := 0; i < 2; i++ { | |||
| for i := 0; i < 3; i++ { | |||
There was a problem hiding this comment.
Maybe a bit slower but using 3 nodes removes the flakiness since etcd won't lose quorum by deleting only one node.
* Fix 2 broken tests * Fix e2e ARP tests: killing one node in a 2 CP node cluster makes etcd lose quorum. So it can't elect a new leader if the node we happen to kill was the etcd leader. * Separate unit tests, e2e tests, linter and scans in different jobs so they run concurrently. Signed-off-by: Guillermo Gaston <gaslor@amazon.com>
|
Looks good and all tests have passed! (Thanks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe there was a reason to not run unit tests but I thought it could be useful to run what we already have and it makes it easier for folks to add more as they write new code.
A couple extra things: