Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to specify DHCP lease hostname #664

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

shkuviak
Copy link
Contributor

Following my previous issue #614 , i made little changes to be able to specify hostname sent to dhcp server when requesting lease using an annotation as the following:

apiVersion: v1
kind: Service
metadata:
  name: nginx-dhcp
  annotations:
    kube-vip.io/loadbalancerHostname: mydhcp-test
spec:
  loadBalancerIP: 0.0.0.0
  ports:
  - name: http
    port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app: hello-world
  type: LoadBalancer

This makes DHCP aware of the hostname and makes the service accessible though local hostname resolution:

curl mydhcp-test.lan

Signed-off-by: Nicolas JENDROWIAK <nico.jendrowiak@gmail.com>
Signed-off-by: Nicolas JENDROWIAK <nico.jendrowiak@gmail.com>
@shkuviak shkuviak force-pushed the feature/service-dhcp-hostname branch from 8a60505 to f0de676 Compare November 24, 2023 16:13
@thebsdbox
Copy link
Collaborator

Nice!

shkuviak and others added 2 commits November 25, 2023 18:22
Signed-off-by: Nicolas JENDROWIAK <75165555+shkuviak@users.noreply.github.com>
Fix trivy warning on vulnerable libcrypto package
-> No newer alpine image on dockerhub

Signed-off-by: Nicolas JENDROWIAK <75165555+shkuviak@users.noreply.github.com>
Copy link
Collaborator

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

This is great, thanks!

@thebsdbox thebsdbox merged commit 247cffb into kube-vip:main Dec 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants