Dualstack support for Loadbalancer Services #687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preliminary step towards dualstack support, I've made some changes to allow handling the case where the field
metadata.annotations["kube-vip.io/loadbalancerIPs"]
has multiple IPs.Right now, there are some cases where I couldn't quite figure out the best UX for multiple loadbalancer IPs for a single service, so for now I'm only supporting dualstack LoadBalancer services in the EnableARP configuration of kube-vip and leaving cases like DHCP, EnableBGP, and uPnP as supporting only one LoadBalancer IP per service. Also egress only supports the first IP in the list of loadbalancer IPs.
I think I'd like to do some more cleanup for this PR, but I've added a test for a dualstack LoadBalancer service and it passes now: