Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cli-options for bgp holdtime and keepalive #730

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Added cli-options for bgp holdtime and keepalive #730

merged 1 commit into from
Jan 16, 2024

Conversation

Cellebyte
Copy link
Collaborator

@Cellebyte Cellebyte commented Jan 16, 2024 •
edited

  • add cli-options to also set the hold_time and keep_alive_interval which were only possible by environment variables.
  • it also uses the defaults of hold_time 30 to keep_alive_interval 10 which should be ok for most environments to start with.

#695

It needs to be documented on https://github.com/kube-vip/website as well

@Cellebyte Cellebyte changed the title Added cli-options for the bgp holdtime and keepalive Added cli-options for bgp holdtime and keepalive Jan 16, 2024
@Cellebyte Cellebyte marked this pull request as ready for review January 16, 2024 13:04
@Cellebyte
Added cli-options for the bgp holdtime and keepalive
bb2c033 
Signed-off-by: Marcel Fest <marcel.fest@telekom.de>
@Cellebyte Cellebyte mentioned this pull request Jan 16, 2024
Open
@thebsdbox thebsdbox merged commit dae044a into kube-vip:main Jan 16, 2024
9 checks passed
@Cellebyte Cellebyte deleted the fix/bgp branch January 16, 2024 13:32
@haijianyang haijianyang mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox Awaiting requested review from thebsdbox thebsdbox is a code owner

@yastij yastij Awaiting requested review from yastij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cellebyte @thebsdbox