No-leader-election mode for BGP and fixes for routing table mode #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
p-strusiewiczsurmacki-mobica
requested review from
thebsdbox and
yastij
as code owners
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
thebsdbox
reviewed
Jan 25, 2024
pkg/manager/watch_endpointslices.go
Outdated
|
|
||
| case watch.Deleted: | ||
| if !sm.config.EnableServicesElection && !sm.config.EnableLeaderElection && sm.config.EnableRoutingTable { | ||
| // When no-leade-elecition mode |
There was a problem hiding this comment.
// When no-leade-elecition mode -> // When no-leader-election mode
There was a problem hiding this comment.
Fixed
|
Looking good! Much left that needs adding? |
|
Any ETA on this @p-strusiewiczsurmacki-mobica ? |
|
Hi @thebsdbox, I'm waiting for @Cellebyte to test it with some real-life setup. I think we should be able to get this done unitl next week max. |
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
|
@thebsdbox and @p-strusiewiczsurmacki-mobica I will build a new image and start testing ;) |
|
So from my testing.
I did not test again the deletion case which was already working as expected in the already merged PR. |
|
Looks good, going to merge this and create a new release! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #729
Added support for non-election-mode for BGP + some fixes for Service Policy in non-leader-election mode in routing table mode.
Additionally fixed some issues I found in BGP mode when global leader election or service election is enabled (e.g addresses were announced but were never deleted.
Current state is:
BGP announcement:
Routing table:
Tagging it as draft for now.