fix: Using log instead of fmt.print #746
Conversation
|
Good find. Would you mind also finding and fixing other places using fmt to print log? On a brief search I find blow places as well Line 172 in 34a4352 kube-vip/cmd/kube-vip-manifests.go Line 57 in 34a4352 kube-vip/cmd/kube-vip-kubeadm.go Line 57 in 34a4352 Thank you |
Signed-off-by: ii2day <ii2day.zoro@gmail.com>
ii2day
force-pushed
the
pr/ii2day/format-log
branch
from
58f4cbc
to
7a93f6f
Compare
Okay, I've searched globally and changed the place for fmt.print to log |
|
Thanks. Dan should have the permission to start the test /ok-to-test |
|
Nice, once this goes through we should be pretty much ready to do the new release |
🎉 By the way, I've noticed that kube-vip's logging doesn't output the number of log lines, which is annoying for people who aren't familiar with kube-vip's code. Is it considered to improve this log output? |
When I was looking at the source code, I noticed that print was being used here, and I felt it would be better to change it to log output.