Added common endpoint provider interface and fixed route deletion iss… #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues in routing table mode Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
p-strusiewiczsurmacki-mobica
requested review from
thebsdbox and
yastij
as code owners
IMO thats not a good idea, as that will lead to people having no clue if they are running a broken or fixed version. IMO the right thing to do is tag 0.7.1 and adding a notice on 0.7.0 |
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
thebsdbox
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ues in routing table mode
This PR introduces common interface for
endpointsandendpointslices. This way endpoints and endpointslices watchers do not have to be maintained separately (as both do mostly the same, but using different Kubernetes resources).Also fixed some issues with routing table cleanup when running in
no-leader-electionmode (e.g. routes were not properly deleted from the node whenlocalpolicy was used if pods were deleted when kube-vip was not running, and then was deployed again).Also this should fix #754 - already exist error will not be logged if route is already there.
I would recommend to create new tag
v0.7.1image with those changes if possible.