Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky e2e test #776

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

lubronzhan
Copy link
Contributor

…ne VIP
Fix #771

Assume VIP is routable even if API server returns 500, since that means VIP is routable, it just might be because etcd is glitching.

Another way to fix is to increase the timeout, but I think better not to increase that since 30s is already a long time
considering the default config

- name: vip_leaseduration
      value: "5"
    - name: vip_renewdeadline
      value: "3"
    - name: vip_retryperiod
      value: "1"

…ne VIP

Signed-off-by: lubronzhan <lubronzhan@gmail.com>
Copy link
Collaborator

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me, Obviously 200 would be better as it proves Kubernetes is up and running.. but we're testing the VIP not the API server.

@thebsdbox thebsdbox merged commit e7eaa70 into kube-vip:main Mar 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the flaky e2e test
2 participants