Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ddns address as a network #795

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: add ddns address as a network #795

merged 1 commit into from
Apr 10, 2024

Conversation

adavis10006
Copy link
Contributor

thebsdbox
thebsdbox approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@thebsdbox
Copy link
Collaborator

Ah, apologies can the merge conflict be addressed and I'll get this merged in.

@adavis10006
fix: add ddns address as a network
2134c6b 
Signed-off-by: Shang-Kuei, Chen <adavis10006@gmail.com>
@adavis10006
Copy link
Contributor Author

@thebsdbox please help review again. Sorry, I must miss the notification during holidays.

@thebsdbox thebsdbox merged commit c9d11e7 into kube-vip:main Apr 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox thebsdbox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adavis10006 @thebsdbox