Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify the ImagePullPolicy used by cli manifest #805

Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix: Modify the ImagePullPolicy used by cli manifest #805

merged 1 commit into from
Apr 7, 2024

Conversation

Bao0ne
Copy link

@Bao0ne Bao0ne commented Apr 4, 2024 •
edited

@Bao0ne Bao0ne requested a review from thebsdbox as a code owner April 4, 2024 12:29
@Bao0ne Bao0ne force-pushed the offline branch 2 times, most recently from c0db88a to 8bed0da Compare April 4, 2024 12:57
lubronzhan
lubronzhan suggested changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@lubronzhan lubronzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change here?

kube-vip/testing/e2e/services/kubernetes.go

Line 152 in f1cf044

ImagePullPolicy: v1.PullAlways,

fix: Modify the ImagePullPolicy used by cli manifest
932fe09 
Signed-off-by: wang <wanglei@tdology.com>
@Bao0ne
Copy link
Author

Bao0ne commented Apr 6, 2024

Could you also change here?

kube-vip/testing/e2e/services/kubernetes.go

Line 152 in f1cf044

ImagePullPolicy: v1.PullAlways,

Sure

lubronzhan
lubronzhan approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@lubronzhan lubronzhan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need Dan's approval

@Cellebyte
Copy link
Collaborator

LGTM,

thanks for the contribution.

@Cellebyte Cellebyte merged commit 0cedf6a into kube-vip:main Apr 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubronzhan lubronzhan lubronzhan approved these changes

@thebsdbox thebsdbox Awaiting requested review from thebsdbox thebsdbox is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bao0ne @Cellebyte @lubronzhan