Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added a volume with a toggle for each app #28

Conversation

InputObject2
Copy link
Contributor

@InputObject2 InputObject2 commented Aug 15, 2022

Fixes #26

If the volumes are not specified, the default is to put everything on the current storage (where the media is). Each tool can create a persistentVolumeClaim if it's volume field is set.

For example to add a config volume for Sonarr:

sonarr:
  enabled: true
  # < ... >
  volume:
    name: pvc-sonarr-config
    storageClassName: longhorn
    annotations:
      my-annotation/test: my-value
    labels:
      my-label/test: my-other-value
    accessModes: ReadWriteOnce
    storage: 5Gi
    selector: {}

@kubealex
Copy link
Owner

Look good to me, I'll run a couple of tests on it and rebuild the new version of the operator if everything is going as expected. Thanks a lot for the effort!

Copy link
Owner

@kubealex kubealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it looks good to me.
Some changes needed:

  • Add a space in each README entries between the first column delimiter and the description
  • Add dashes in the if/else/end statements to avoid blank lines in template rendering in *-resources.yml
  • Same as before in storage-resources.yml file for those that are missing.

After you do this I will merge it and rebuild the operator :)

Thanks a lot!

@InputObject2 InputObject2 force-pushed the feature/separate-config-volumes-per-app branch 4 times, most recently from 02f2881 to 32cd7d1 Compare November 11, 2022 04:18
@InputObject2
Copy link
Contributor Author

Sorry for leaving the PR pending this long, I just sent it and completely forgot about it.

Add a space in each README entries between the first column delimiter and the description

fixed

Add dashes in the if/else/end statements to avoid blank lines in template rendering in *-resources.yml

fixed

Same as before in storage-resources.yml file for those that are missing.

I rebased on dc5b9ac and I went through the file and we have all the same sections except the ones I added, but not in the same order? Did you use a linter or something to remake the file?

@InputObject2 InputObject2 force-pushed the feature/separate-config-volumes-per-app branch from 32cd7d1 to 52e371e Compare November 11, 2022 04:40
@InputObject2 InputObject2 changed the title Added a volume with a toggle for each app feat(chart): Added a volume with a toggle for each app Nov 11, 2022
@kubealex kubealex self-assigned this Nov 26, 2022
@kubealex kubealex changed the base branch from master to release-0.7.0 November 26, 2022 14:52
Copy link
Owner

@kubealex kubealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubealex kubealex merged commit dafceb9 into kubealex:release-0.7.0 Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Having different PV for each tool
2 participants