Fix nodeSelector and its associated documentation. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the templates and README.md referenced a general.nodeSelector field that didn't exist in helm-charts/k8s-mediaserver/values.yaml or k8s-mediaserver.yml files. Conversely, those yaml/yml files allow for per-pod node selection, which allows for more flexibility. We've gotta resolve this inconsistency somehow, so let's maintain the general approach as documented but merge in service-specific selectors for improved flexibility.
|
Thank you so much for your contribution @mcsaucy and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the templates and README.md referenced a general.nodeSelector field that didn't exist in
helm-charts/k8s-mediaserver/values.yaml or k8s-mediaserver.yml files. Conversely, those yaml/yml files allow for per-pod node selection, which allows for more flexibility. We've gotta resolve this inconsistency somehow, so let's maintain the general approach as documented but merge in service-specific selectors for improved flexibility.