fix(charts): Added extraLBAnnotations and fixed mismatched ports #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransmission and sabnzbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of the issues with the extra loadbalancer service raised in #71
Manually tested working with on/off load balancers and annotations. The ports also now work.
Possible breakage
.Values.transmission.service.port was previously unset in the chart values, but determined users might have set them to overcome error messages that the chart or operator would have raised. Those configs would now be ignored to reflect what was really in the values.yaml file (and previously in the transmission-resources.yaml file).
We can also go the other way around and unset utp and set default values for .Values.transmission.service