Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versions.json #452

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Remove versions.json #452

merged 1 commit into from
Jan 5, 2023

Conversation

tu1h
Copy link
Member

@tu1h tu1h commented Jan 4, 2023

Signed-off-by: tu1h lihai.tu@daocloud.io

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
file versions.json is not used in repo currently and long term, so remove it.

Which issue(s) this PR fixes:

Fixes #441

Special notes for your reviewer:

@kubean-pr-robot kubean-pr-robot bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 4, 2023
@kubean-pr-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tu1h
To complete the pull request process, please assign yunshihang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yunshihang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: tu1h <lihai.tu@daocloud.io>
@hangscer8
Copy link
Collaborator

/lgtm

@kubean-pr-robot kubean-pr-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@ErikJiang
Copy link
Member

/lgtm

@ErikJiang ErikJiang merged commit f9a3606 into kubean-io:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

software bug: the kubean version should be showed in versions.json
3 participants