Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly e2e helm version set #466

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix nightly e2e helm version set #466

merged 1 commit into from
Jan 9, 2023

Conversation

wenting-guo
Copy link
Contributor

Signed-off-by: bell.guo wenting.guo@daocloud.io

What type of PR is this?

/kind feature

What this PR does / why we need it:
fix bug: when a tag is newly created, then run the nightly e2e, will fail. Because of fetched wrong helm version

Signed-off-by: bell.guo <wenting.guo@daocloud.io>
@kubean-pr-robot kubean-pr-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 9, 2023
@ErikJiang
Copy link
Member

/lgtm

@kubean-pr-robot kubean-pr-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@kubean-pr-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, wenting-guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubean-pr-robot kubean-pr-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@ErikJiang ErikJiang merged commit 7724126 into main Jan 9, 2023
@wenting-guo wenting-guo deleted the e2e-helm-version branch January 12, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants