Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allinone.md #749

Merged
merged 2 commits into from
May 23, 2023
Merged

Update allinone.md #749

merged 2 commits into from
May 23, 2023

Conversation

yanrongshi
Copy link
Contributor

@yanrongshi yanrongshi commented May 23, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  • Update the information architecture, prioritize the "Quick Start" section, and move "Release" to the bottom
  • Decompose the "install.md" document to reduce user cognitive load. In the future, accelerator mode, pure offline mode, and SSH key mode will be added as separate documents.
    • rm install.md
    • add all-in-one-install.md
    • add helm-install-kubean.md

Special notes for your reviewer:
@ErikJiang

@kubean-pr-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanrongshi
To complete the pull request process, please assign erikjiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @erikjiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanrongshi
Copy link
Contributor Author

yanrongshi commented May 23, 2023

Screenshot of local build

image
image
image
image

@yanrongshi
Copy link
Contributor Author

/kind documentation

@kubean-pr-robot kubean-pr-robot bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 23, 2023
@yanrongshi
Copy link
Contributor Author

yanrongshi commented May 23, 2023

how do you think about this request:#750 @ErikJiang

@ErikJiang
Copy link
Member

/lgtm

@kubean-pr-robot kubean-pr-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@ErikJiang ErikJiang merged commit 3950a76 into kubean-io:main May 23, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants