Don't panic in ParseDriverType #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related discussion: vmware-tanzu#1359 (comment)
andresmgot
approved these changes
Dec 11, 2019
cmd/kubeops/main.go
Outdated
| driverType = agent.ParseDriverType(helmDriverArg) | ||
| d, err := agent.ParseDriverType(helmDriverArg) | ||
| if err != nil { | ||
| panic(err.Error()) |
There was a problem hiding this comment.
you can just do panic(err)
| @@ -90,16 +91,16 @@ func createStorage(driverType DriverType, namespace string, clientset *kubernete | |||
| return store | |||
| } | |||
|
|
|||
| func ParseDriverType(raw string) DriverType { | |||
| func ParseDriverType(raw string) (DriverType, error) { | |||
There was a problem hiding this comment.
this function is simple but it'd be good to have a simple test
I have fixed those issues now! 😃 |
andresmgot
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
It rewrites
agent.ParseDriverTypeto return an error instead of panicking if it doesn't recognize its input.Benefits
ParseDriverTypeis made more faithful to its declared type.main.gothat the application may panic.Possible drawbacks
ParseDriverTypebecomes more verbose.Applicable issues
Excerpt from a related discussion with @andresmgot in #1359: