OperatorInstance view #1594
Merged
OperatorInstance view #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Mar 20, 2020
| return ( | ||
| <InfoCard | ||
| key={resource.metadata.name} | ||
| link={`/operators-instances/ns/${resource.metadata.namespace}/${resource.metadata.name}`} | ||
| link={`/operators-instances/ns/${resource.metadata.namespace}/${csv.metadata.name}/${crd?.name}/${resource.metadata.name}`} |
There was a problem hiding this comment.
Won't the crd?.name leave either the string 'undefined' or at best, '' so there will be two slashes?
There was a problem hiding this comment.
yes, the thing is that crd will never be empty if resource is populated since the crd is required to obtain the resource. Typescript is not helping here a lot but I will try to make it more readable.
| @@ -227,7 +227,9 @@ class DeploymentFormBody extends React.Component< | |||
| this.setState({ submittedResourceName: resourceName }); | |||
| const created = await createResource(namespace, resource.apiVersion, resourceType, resource); | |||
| if (created) { | |||
| push(`/operators-instances/ns/${namespace}/${resourceName}`); | |||
| push( | |||
| `/operators-instances/ns/${namespace}/${csv?.metadata.name}/${crd?.name}/${resourceName}`, | |||
* Add delete button * Reset state when changing the namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Draft for the OperatorInstance view:
For the moment we are showing just some basic info. The current status (as a YAML) and the installation values along with a Card with basic information about the CRD and the ClusterServiceVersion. The plan is to keep adding things but in other PRs to facilitate the review. The next things I plan to add are:
We should also be able to modify the instance but I will leave that for later.
Applicable issues