Fix card shrink in Catalog #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2020 17:33
absoludity
approved these changes
Apr 9, 2020
| @@ -143,7 +143,7 @@ class Catalog extends React.Component<ICatalogProps, ICatalogState> { | |||
| </div> | |||
| </div> | |||
| )} | |||
| <div className={this.shouldRenderOperators() ? "col-10" : ""}> | |||
| <div className={this.shouldRenderOperators() ? "col-10" : "col-12"}> | |||
There was a problem hiding this comment.
Why is this dependent on whether we're rendering operators? That is, why not use the same width ("col-10") either way? If it's because the filter is not present, then we should use a function that makes that obvious, perhaps?
There was a problem hiding this comment.
yes, it's because if there are no operators we are skipping the column that allows you to filter by chart/operator. This function is used several times (line 102 and 121), I guess it's more obvious in the full context of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When there are less than 4 cards in the catalog, these cards shrink
We need to set the CSS properties to fill the whole row.