Bump remark-gfm from 1.0.0 to 2.0.0 in /dashboard #3248
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/dashboard/remark-gfm-2.0.0
branch
from
d4bcc9e
to
6c67167
Compare
Bumps [remark-gfm](https://github.com/remarkjs/remark-gfm) from 1.0.0 to 2.0.0. - [Release notes](https://github.com/remarkjs/remark-gfm/releases) - [Commits](remarkjs/remark-gfm@1.0.0...2.0.0) --- updated-dependencies: - dependency-name: remark-gfm dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/dashboard/remark-gfm-2.0.0
branch
from
6c67167
to
3915e3e
Compare
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
| @@ -147,7 +147,7 @@ | |||
| "!src/**/*.d.ts" | |||
| ], | |||
| "transformIgnorePatterns": [ | |||
| "node_modules/(?!@clr|@cds|lit|@lit|ramda|lodash-es|.*css)" | |||
| "node_modules/(?!@cds|@clr|@lit|bail|ccount|character-entities|comma-separated-tokens|escape-string-regexp|is-plain-obj|lit|lodash-es|markdown-table|mdast-util-definitions|mdast-util-find-and-replace|mdast-util-from-markdown|mdast-util-gfm|mdast-util-gfm-autolink-literal|mdast-util-to-hast|mdast-util-to-markdown|mdast-util-to-string|micromark|micromark-core-commonmark|parse-entities|property-information|ramda|react-markdown|remark-gfm|remark-parse|remark-rehype|space-separated-tokens|trough|unified|unist-builder|unist-util-generated|unist-util-is|unist-util-position|unist-util-stringify-position|unist-util-visit|unist-util-visit-parents|util-find-and-replace|vfile|vfile-message|.*css)" | |||
There was a problem hiding this comment.
For some deps we can come up with some regex catching unist-* and mdast-*, but I don't know if we better declare them explicitly to avoid unnoticed issues.
However, it is just for running jest tests, so we will know really quickly if something fails.
cc @absoludity
There was a problem hiding this comment.
Sorry, I missed the cc earlier. Yeah, given this is just jest config, I'm not too worried. I'm surprised that updating remark-gfm lead to this though (many of the packages just seem to be upgraded... did the previous versions not require transformation?).
Anyway, +1 from me - I generally prefer explicit, but for a huge regex like this for a test module... don't care :)
There was a problem hiding this comment.
No problem, the ping was mainly for squeezing this PR in the 2.3.4 release, but it's not critical whatsoever.
As many deps are migrating to ES Modules, the jest tests fail. This is an open issue in jest, but they do have some workarounds (see https://jestjs.io/docs/ecmascript-modules).
The currently chosen tweak is the easiest one, declaring each module in transformIgnorePatterns, but it is tedious if a module has many transitive ESM deps (as in this case).
I've seen another dependabot upgrade is also similar, so we need to handle this problem in a more scalable way at some point.
So, what I would suggest is to go ahead with this PR (and perhaps the existing ones), but create a task for looking for a long-term solution.
| @@ -147,7 +147,7 @@ | |||
| "!src/**/*.d.ts" | |||
| ], | |||
| "transformIgnorePatterns": [ | |||
| "node_modules/(?!@clr|@cds|lit|@lit|ramda|lodash-es|.*css)" | |||
| "node_modules/(?!@cds|@clr|@lit|bail|ccount|character-entities|comma-separated-tokens|escape-string-regexp|is-plain-obj|lit|lodash-es|markdown-table|mdast-util-definitions|mdast-util-find-and-replace|mdast-util-from-markdown|mdast-util-gfm|mdast-util-gfm-autolink-literal|mdast-util-to-hast|mdast-util-to-markdown|mdast-util-to-string|micromark|micromark-core-commonmark|parse-entities|property-information|ramda|react-markdown|remark-gfm|remark-parse|remark-rehype|space-separated-tokens|trough|unified|unist-builder|unist-util-generated|unist-util-is|unist-util-position|unist-util-stringify-position|unist-util-visit|unist-util-visit-parents|util-find-and-replace|vfile|vfile-message|.*css)" | |||
There was a problem hiding this comment.
Sorry, I missed the cc earlier. Yeah, given this is just jest config, I'm not too worried. I'm surprised that updating remark-gfm lead to this though (many of the packages just seem to be upgraded... did the previous versions not require transformation?).
Anyway, +1 from me - I generally prefer explicit, but for a huge regex like this for a test module... don't care :)
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: dashboard/yarn.lock
antgamdia
deleted the
dependabot/npm_and_yarn/dashboard/remark-gfm-2.0.0
branch
Bumps remark-gfm from 1.0.0 to 2.0.0.
Release notes
Sourced from remark-gfm's releases.
Commits
383f4182.0.054b2adaUpdatexo37d92acAdd JSDoc based types0846014Remove warning for remark 121785879Update docs9bc5759Refactor code-style331d940Update dependencies6c518d8Use ESM93b0afbReplacenycwithc8902b287Update Node in ActionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)