Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new vhost path #427

Merged
merged 5 commits into from
Aug 3, 2018
Merged

Use new vhost path #427

merged 5 commits into from
Aug 3, 2018

Conversation

andresmgot
Copy link
Contributor

Fixes #424

@andresmgot
Copy link
Contributor Author

cc/ @arapulido

arapulido
arapulido approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@arapulido arapulido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arapulido
Copy link
Contributor

@andresmgot actually, can we move to a -rX tag for now, please? Here and in the chart, to avoid future breakage

@andresmgot
Copy link
Contributor Author

👍

arapulido
arapulido approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@arapulido arapulido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@andresmgot andresmgot merged commit 78b2d87 into vmware-tanzu:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arapulido arapulido arapulido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresmgot @arapulido