Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack link to Readme #701

Merged
merged 5 commits into from
Oct 5, 2018
Merged

Conversation

migmartri
Copy link
Contributor

@migmartri migmartri commented Oct 4, 2018

Followed a similar approach as seen in other projects like Minikube.

NOTE: I decided not to add this badge but let me know if you think otherwise

Slack

Closes #610

@migmartri migmartri changed the title Add slack link in Readme Add Slack link to Readme Oct 4, 2018
README.md Outdated

## Community

* [#kubeapps on Kubernetes Slack](https://kubernetes.slack.com/messages/C9D3TSUG4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm links to https://kubernetes.slack.com/messages/helm-users so we should be able to use https://kubernetes.slack.com/messages/kubeapps. Also we should instruct people on how to join this slack (link to slack.k8s.io, as it's not obvious.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm links to https://kubernetes.slack.com/messages/helm-users so we should be able to use https://kubernetes.slack.com/messages/kubeapps.

The reason why I used the ID is because it seems that sometimes using /kubeapps the link gets lost after signing in and was landing in #announcements (I reproduced it a couple of times, but is not constant). I'll change it though.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, interesting - I'm fine either way

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!!

@migmartri migmartri merged commit c6bccdf into vmware-tanzu:master Oct 5, 2018
@migmartri migmartri deleted the 610-slack branch October 5, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants