fix(CI): add the job to run go test on the KubeArmor/KubeArmor directory #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @haytok thanks for this PR, can you please handle the failing issue with this PR itself? thanks again. |
|
Hi, @rksharma95 |
|
@haytok PR LGTM, can you please squash the commits. thanks |
…ory and fix to pass the tests The current implementation does not have a job in CI to run tests for golang programs under the KubeArmor/KubeArmor directory. Therefore, this commit will add the job to ci-test-go.yml to run tests for golang programs under the KubeArmor/KubeArmor directory. On the other hand, in the current implementation, the following error occurs when go test is executed in the directory KubeArmor/KubeArmor/core. > go test # github.com/kubearmor/KubeArmor/KubeArmor/core ./karmorprobedata.go:61:3: (*github.com/kubearmor/KubeArmor/KubeArmor/feeder.Feeder).Errf format %s reads arg kubearmor#1, but call has 0 args Thus, if test_kubearmor.sh or go test ./... on the kubearmor/kubeArmor are run, the test will fail. The test fails because dm.Logger.Errf(), which is called in the SetKarmorData function in the file core/karmorprobedata.go, is missing an argument for the format specifier. Therefore, this commit will fix it to add a variable for the format specifiers so that the test will succeed properly. Signed-off-by: Hayato Kiwata <simplelpmis6@gmail.com>
haytok
force-pushed
the
fix-to-run-golang-tests-on-ci
branch
from
27a6b4f
to
87f99c9
Compare
|
@rksharma95 |
daemon1024
approved these changes
Jun 29, 2023
|
Thanks for merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not have a job in CI to run tests for golang programs under the KubeArmor/KubeArmor directory.
Therefore, this commit will add the job to ci-test-go.yml to run tests for golang programs under the KubeArmor/KubeArmor directory.
Purpose of PR?:
Fixes #
I haven't created an issue. However, in the pull request #1264 , we were advised to add a CI to run tests of golang programs under KubeArmor/KubeArmor directory. Specifically, this part is applicable.
Does this PR introduce a breaking change?
No.
I added a job to
ci-test-go.ymlwith this commit.If the changes in this PR are manually verified, list down the scenarios covered::
In the CI job, tests of golang programs can be run in the KubeArmor/KubeArmor directory.
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Attached below is a screenshot of running the job I added in my verification environment.
Note that at the moment, the test fails at the process in
KubeArmor/KubeArmor/core/karmorprobedata.go:61:17as shown in the image. I will try to fix this in another pull request.Checklist:
<type>(<scope>): <subject>