Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Introduce Scripts for K3s and KubeArmor Installation with Error Prevention for killercoda-specific Kubernetes Setup #1493

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

udit-uniyal
Copy link
Contributor

@udit-uniyal udit-uniyal commented Nov 4, 2023

Purpose of PR:

This PR introduces a new script named k3s_installation_killercoda.sh designed to address multiple key objectives in a Kubernetes setup. facilitates the installation of a K3s Kubernetes cluster ensures that all pods in the "kube-system" namespace are in the "Running" state before proceeding with any further actions. and kubearmor_installation_view.sh facilitates the installation ensures that all pods in the "kubearmor" namespace are in the "Running" state before proceeding with any further actions specific to helm kubearmor installation.

Error Prevention: In specific environments or contexts, such as "killercoda," persistent errors may have been observed with default setup. This script aims to address and prevent such errors, contributing to the overall robustness of the setup.

Does this PR introduce a breaking change?

No, this PR does not introduce any breaking changes.

Scenarios Covered:

Installation of a K3s Kubernetes cluster and Verification that all pods in the "kube-system" namespace are in the "Running" state.
Installation of a KubeArmor and Verification that all pods in the "kubearmor" namespace are in the "Running" state.

Additional Information for Reviewer:
This PR is part of an ongoing effort to enhance the Kubernetes setup and address potential issues observed in specific contexts, like "killercoda."

Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

@Ankurk99
Copy link
Member

Ankurk99 commented Nov 4, 2023

Can you squash all the commits into one and sign it?

@Ankurk99
Copy link
Member

Ankurk99 commented Nov 4, 2023

Also, do we need to update the documentation for the Killercoda env?

@udit-uniyal
Copy link
Contributor Author

Can you squash all the commits into one and sign it?

sure. will do that.

@udit-uniyal
Copy link
Contributor Author

Also, do we need to update the documentation for the Killercoda env?

No documentation has been created for the Killercoda environment yet, but I'll create it.

@udit-uniyal
Copy link
Contributor Author

Done. Ready to merge.

Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commit, rest LGTM

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: udit-uniyal <udituniyal71@gmail.com>
@Ankurk99 Ankurk99 merged commit 4c4d9dd into kubearmor:main Nov 6, 2023
10 checks passed
Srijan-SS02 pushed a commit to Srijan-SS02/KubeArmor that referenced this pull request Nov 9, 2023
…h Error Prevention for killercoda-specific Kubernetes Setup (kubearmor#1493)

Signed-off-by: Srijan-SS02 <codeofficialsrijansriv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants