Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle visibility if namespace info is missing #1521

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rksharma95
Copy link
Collaborator

Purpose of PR?:

this PR fixes Visibility Issue that might occur due to Pod-Container event latency. in case if container runtime detect the containers and emit those events before the pod events then the namespace value will not be present and the visibility will be defined incorrectly irrespective of namespace level visibility configuration.

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit changes in enforcer/*

Signed-off-by: rksharma95 <ramakant@accuknox.com>
@rksharma95 rksharma95 merged commit 718f829 into kubearmor:main Nov 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants