fix(crd): add omitempty in spec for crds #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
requested changes
Dec 14, 2023
pkg/KubeArmorController/api/security.kubearmor.com/v1/common.go
Outdated
Show resolved
Hide resolved
pkg/KubeArmorController/api/security.kubearmor.com/v1/common.go
Outdated
Show resolved
Hide resolved
rajaSahil
force-pushed
the
fix-crd
branch
2 times, most recently
from
d826736
to
1dd4e7f
Compare
daemon1024
requested changes
Dec 15, 2023
pkg/KubeArmorController/api/security.kubearmor.com/v1/common.go
Outdated
Show resolved
Hide resolved
rajaSahil
force-pushed
the
fix-crd
branch
2 times, most recently
from
ebcc6a7
to
8b18cac
Compare
nyrahul
approved these changes
Dec 18, 2023
daemon1024
approved these changes
Dec 18, 2023
|
Can you rebase PR again 😓 the tests should be fixed now. |
Signed-off-by: sahil <sahilraja242@gmail.com>
daemon1024
approved these changes
Feb 1, 2024
|
Can we merge this? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #
MatchCapabilitiesTypeandMatchProtocols.Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>