chore(tests): cleanup unused code and add sleep to prevent flakiness #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmor logs internally has it's own port-forward, we don't need to run portforward on kubearmor container before hand due to slow nature of github action runners, we have added time.sleep at a lot of places, adding at a few more places which is showing increased flaky behaviour Signed-off-by: daemon1024 <barun1024@gmail.com>
DelusionalOptimist
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
karmor logs internally has it's own port-forward, we don't need to run portforward on kubearmor container before hand
Due to slow nature of github action runners, we have added time.sleep at a lot of places, adding at a few more places which is showing increased flaky behaviour
Github Actions chose to get slower when we released, so here's a reminder to get more sleep 馃槾 馃槾
Hopefully stabilises the CI 馃馃徑
Ps. added sleep while being sleep deprived