Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Issues with host policy application #1640

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

DelusionalOptimist
Copy link
Member

Purpose of PR?:

  • Fixes policies not getting applied in non-k8s mode.
  • If delete event for a policy which didn't exist was sent to KubeArmor, it would go into deadlock and won't let any other policy functions work.
  • Match identity for host policy received over gRPC so that a policy not meant for this host is not applied.

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::

  • Delete a host policy which doesn't exist won't deadlock now.

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com>
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏽

@daemon1024 daemon1024 merged commit c0b8d3d into kubearmor:main Feb 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants