updated go version to 1.21.8 #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the errors in CI due to old go.sum? cc @DelusionalOptimist |
|
|
kranurag7
reviewed
Mar 6, 2024
|
@VedRatan use kubernetes-sigs/controller-tools#880 , basically update the controller-gen module to 0.14 to fix it |
Yes I am upgrading the controller-gen, will be pushing the changes now. |
daemon1024
reviewed
Mar 7, 2024
DelusionalOptimist
force-pushed
the
latest_go
branch
2 times, most recently
from
74c6fb2
to
51defd6
Compare
DelusionalOptimist
changed the title
|
Sorry @VedRatan... had to take this over as it was blocking CI for all other PRs for the upcoming release. : ( |
|
No issues @DelusionalOptimist |
DelusionalOptimist
force-pushed
the
latest_go
branch
from
86dabf3
to
0238dfe
Compare
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
DelusionalOptimist
force-pushed
the
latest_go
branch
from
0238dfe
to
461b013
Compare
daemon1024
approved these changes
Mar 7, 2024
DelusionalOptimist
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
This PR updates go version to latest one 1.22 including the CI.Attempted to update to go 1.22 but snyk doesn't support it apparently. Will stick with go1.21.8 for now which has all the needed vuln. fixes backported.
Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>