Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added column in ksp and hsp -owide #1683

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

sratslla
Copy link
Contributor

Purpose of PR?:

Fixes #1326

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
image

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes feat: add more columns for ksp  #1326
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sratslla is it possible to make selector a comma separated list instead of raw JSON? 🤔

@sratslla
Copy link
Contributor Author

Hi @DelusionalOptimist
I tried to find a way around it, but I found nothing. There is also nothing in the documentation. I guess Kubebuilder does not offer to manipulate the data like this.

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's keep the JSON thing. Thanks a lot 🙌🏽

Signed-off-by: sratslla <shubhgaur.cse24@jecrc.ac.in>
@daemon1024 daemon1024 merged commit fee50c9 into kubearmor:main Mar 15, 2024
8 checks passed
@sratslla sratslla deleted the i1326 branch March 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add more columns for ksp
3 participants