Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enforcer/bpflsm): panic during bpflsm cleanup #1686

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Mar 14, 2024

Purpose of PR?:

  • panic during bpflsm cleanup
  • fix missing proc name in alerts

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@Aryan-sharma11
Copy link
Member

The changes makes sense, although I noticed one thing, if in case BPFLSM fails to load we move on to AppArmor, so if we install Kubearmor using operator ,it would still be showing podname kubermor-bpf-crio even if we are running apparmor under the hood.
Can we handle that wdyt?

@daemon1024
Copy link
Member Author

@Aryan-sharma11 I don't think we can handle that right now. But we need to think about how to handle that in the operator refactor. Let's handle that seprately.

Signed-off-by: daemon1024 <barun1024@gmail.com>
Signed-off-by: daemon1024 <barun1024@gmail.com>
@daemon1024 daemon1024 merged commit 5408a4e into kubearmor:main Mar 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants