Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): extend grpc maxrecvmsg size for cri handlers #1709

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

rksharma95
Copy link
Collaborator

Purpose of PR?:

when there are a lot of containers running, it might exceed the default grpc limit of 4MB msg size for cri handler services and that will lead to the issues.

rpc error: code = ResourceExhausted desc = grpc: received message larger than max

Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: rksharma95 <ramakant@accuknox.com>
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle this for docker socket as well?

@rksharma95
Copy link
Collaborator Author

Do we need to handle this for docker socket as well?

in case of docker we're using http client https://pkg.go.dev/github.com/docker/docker@v24.0.7+incompatible/client , it's not needed in this case.

Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DelusionalOptimist DelusionalOptimist merged commit cdfe3f8 into kubearmor:main Apr 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants